EngineDev/imgui-mirror
1
0
Fork 0
mirror of https://github.com/ocornut/imgui.git synced 2026-11-06 06:25:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

DrawList: AddRect: avoid altering rounding on StrokeOutside when initial value if 0 + comments

Browse Source
This commit is contained in:
ocornut 2026-05-05 20:18:03 +02:00
parent b9707d72ab
commit 80096045d9
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
imgui_draw.cpp
View File

@ -1738,17 +1738,22 @@ void ImDrawList::AddRect(const ImVec2& p_min, const ImVec2& p_max, ImU32 col, fl
int s_rounding = (int)(rounding / _FringeScale); int s_rounding = (int)(rounding / _FringeScale);
int s_thickness = (int)(thickness / _FringeScale); int s_thickness = (int)(thickness / _FringeScale);
// AddRectBaked() renders the stroke inside the rectangle, so we need to adjust the outside case
// This branch does not handle the center, since odd thickness strokes are not pixel aligned, even if the rectangle is.
ImVec2 s_min = p_min; ImVec2 s_min = p_min;
ImVec2 s_max = p_max; ImVec2 s_max = p_max;
if (stroke_pos == ImDrawFlags_StrokeOutside) if (stroke_pos == ImDrawFlags_StrokeOutside)
{ {
s_min -= ImVec2(thickness, thickness); s_min -= ImVec2(thickness, thickness);
s_max += ImVec2(thickness, thickness); s_max += ImVec2(thickness, thickness);
s_rounding += s_thickness; if (s_rounding != 0.0f)
s_rounding += s_thickness;
} }
// FIXME-WIP: Why isn't rounding offset in the _StrokeInside case?
if (s_rounding <= 0 || (flags & ImDrawFlags_RoundCornersMask_) == ImDrawFlags_RoundCornersNone) if (s_rounding <= 0 || (flags & ImDrawFlags_RoundCornersMask_) == ImDrawFlags_RoundCornersNone)
{ {
// FIXME-WIP: This could use half the number of vertices.
const float t = (float)s_thickness * _FringeScale; const float t = (float)s_thickness * _FringeScale;
PrimReserve(6*4, 4*4); PrimReserve(6*4, 4*4);
PrimRect(ImVec2(p_min.x, p_min.y), ImVec2(p_max.x, p_min.y + t), col); PrimRect(ImVec2(p_min.x, p_min.y), ImVec2(p_max.x, p_min.y + t), col);