EngineDev/imgui-mirror
1
0
Fork 0
mirror of https://github.com/ocornut/imgui.git synced 2026-11-06 06:25:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

Internals: CallContextHooks(): fixed iterating a reallocated array when a hook callback adds a hook.

Browse Source 
A callback calling AddContextHook(), e.g. an extension registering its hooks on first use from inside another hook, could reallocate g.Hooks while CallContextHooks() iterated it with a range-based for loop. Later hooks were then skipped or read from freed memory.
This commit is contained in:
thedmd 2026-10-16 22:48:02 +02:00
parent 5026ac18ec
commit 46e4edc5f8
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
imgui.cpp
View File

@ -4727,12 +4727,13 @@ void ImGui::RemoveContextHook(ImGuiContext* ctx, ImGuiID hook_id)
// Call context hooks (used by e.g. test engine)
// We assume a small number of hooks so all stored in same array
// Iterate by index: a callback may add a hook, which reallocates the array. Hooks added here are called from the next call.
void ImGui::CallContextHooks(ImGuiContext* ctx, ImGuiContextHookType hook_type)
{
ImGuiContext& g = *ctx;
for (ImGuiContextHook& hook : g.Hooks)
if (hook.Type == hook_type)
hook.Callback(&g, &hook);
for (int n = 0, hooks_count = g.Hooks.Size; n < hooks_count; n++)
if (g.Hooks[n].Type == hook_type)
g.Hooks[n].Callback(&g, &g.Hooks[n]);
}
//-----------------------------------------------------------------------------